feat: allow specification of height and width for landscape #12921
feat: allow specification of height and width for landscape #12921mcanouil wants to merge 2 commits intoquarto-dev:mainfrom
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
| if div.classes:includes('landscape') then | ||
| if FORMAT:match 'docx' then | ||
| -- DOCX-specific landscape orientation | ||
| local height = div.attributes.height or "8.5in" |
There was a problem hiding this comment.
I understand why you added unit handling here, but this makes me think that we need to figure out how to get unit handling to behave uniformly across Quarto.
There was a problem hiding this comment.
@gordonwoodhull What do you think if we took the code you wrote in src/resources/filters/modules/typst_css.lua and made it a general-purpose Lua module to be used across our filters? It would require a bit of refactoring, but I think it's worth it.
There was a problem hiding this comment.
Feel free to take over the PR.
It was mostly a proof of concept of what it could be.
There was a problem hiding this comment.
Sure! The routines in typst_css.lua
- parse a CSS length with suffix
- output the Typst equivalent of a parsed length, where 5 out of 43 length units pass through, and two are translated (
pxand the pseudo-unit%).
I guess what we'd do is move the parse functions to, like, a parse_css module, and then write length output functions for other output formats, where docx always outputs to twips with no suffix.
And we could leave the door open to generalize colors in the same way later.
|
Thanks! We need a changelog entry and tests as well. |
4 participants
Introduce the ability to set custom height and width for landscape sections in DOCX format, enhancing document formatting flexibility. Default values are provided if none are specified.